search

keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
21.34k stars 1.47k forks source link

Statement on CVE-2023-24055? #9041

Open lathspell opened 1 year ago

lathspell commented 1 year ago

It would be nice if you could add some kind of statement on the website or release notes, whether or not KeePassXC is affected from the recent security bug in the KeePass project.

https://nvd.nist.gov/vuln/detail/CVE-2023-24055

phoerious commented 1 year ago

KeePassXC is not affected, because it doesn't support triggers.

lionkmp commented 1 year ago

What if an attacker edits the config and instructs my KeePassXC to export my database into a file? By editing this section. So what when I start it next time? (I don't know, I'm just asking.)

[KeeShare]
Active="<?xml version=\"1.0\...

(ps: I agree with original KeePass response saying that if an attacker can write there, it's already doomed. And I don't know if this section by itself - in KeePassXC can instruct the program to do an export or import. I can see my import path in there.)

Maybe the export/import settings could be within the encrypted database, rather than in the ini file?

droidmonkey commented 1 year ago

That setting has absolutely nothing to do with exporting database entries. That is your signing key used by keeshare which is a feature that is no longer used for any meaningful purpose.

Cologler commented 1 year ago

If someone can edit your files, why don't they just replace your keepassxc.exe with a fake keepassxc?

droidmonkey commented 1 year ago

@Cologler

  1. If you installed keepassxc then it would be placed in a protected area of the operating system (one that requires admin access). Then this attack is not possible as a normal user.

  2. The config files are stored in user editable directories by necessity.

Cologler commented 1 year ago

@droidmonkey The installer need admin premission. So when the user install the software from attacker, the attacker already got the admin premission.

droidmonkey commented 1 year ago

If you run malware as an admin there is nothing anyone or thing can do to protect you.

Cologler commented 1 year ago

@droidmonkey I agree with KeePass and KeePassXC can only protect us when the database is closed, so we can place the database on the cloud service.