keepassxreboot / keepassxc

KeePassXC is a cross-platform community-driven port of the Windows application “Keepass Password Safe”.
https://keepassxc.org/
Other
20.79k stars 1.44k forks source link

File name convention suggestion #9826

Open Rexadev opened 1 year ago

Rexadev commented 1 year ago

For example - https://github.com/keepassxreboot/keepassxc/releases/tag/2.7.6

Files should be named - KeePassXC-version-OS-Archtechture-Type.FileExtension

Why

They would be sorted by OS

For example these KeePassXC-2.7.6-x86_64.dmg KeePassXC-2.7.6-x86_64.dmg.DIGEST KeePassXC-2.7.6-x86_64.dmg.sig and these are separate - KeePassXC-2.7.6-arm64.dmg KeePassXC-2.7.6-arm64.dmg.DIGEST KeePassXC-2.7.6-arm64.dmg.sig

Also KeePassXC-2.7.6-x86_64.AppImage doesn't have OS name in it.

Are these different -

keepassxc-2.7.6-src.tar.xz keepassxc-2.7.6-src.tar.xz.DIGEST keepassxc-2.7.6-src.tar.xz.sig from this - [Source code] (https://github.com/keepassxreboot/keepassxc/archive/refs/tags/2.7.6.zip) [Source code (tar.gz)] (https://github.com/keepassxreboot/keepassxc/archive/refs/tags/2.7.6.tar.gz)

droidmonkey commented 1 year ago

@phoerious I tend to agree but it'll break our website big time if we make a shift

michaelk83 commented 1 year ago

If you know how the filenames will change, you can set up your server to give a 301 redirect from the old filenames to the new ones. For example, KeePassXC-([0-9.]+)-x86_64.dmg would redirect to KeePassXC-$1-MacOS-x86_64.dmg. (The $1 inserts the version string captured in the above regex.)

Or just do a search-and-replace on the links themselves.

droidmonkey commented 1 year ago

I was overthinking this morning, we don't host previous version links on our website we just redirect to github. This is a non issue for the website.

phoerious commented 1 year ago

We have a naming scheme, we should stick with it. There is not really a reason to change it.

droidmonkey commented 1 year ago

Well I kind of violate that naming scheme with "Win64" would it kill us to write "macos-arm64" and "macos-x86_64"

Rexadev commented 1 year ago

@droidmonkey @phoerious Are these different -

keepassxc-2.7.6-src.tar.xz keepassxc-2.7.6-src.tar.xz.DIGEST keepassxc-2.7.6-src.tar.xz.sig from this - [Source code] (https://github.com/keepassxreboot/keepassxc/archive/refs/tags/2.7.6.zip) [Source code (tar.gz)] (https://github.com/keepassxreboot/keepassxc/archive/refs/tags/2.7.6.tar.gz)

phoerious commented 1 year ago

Yes.

Rexadev commented 1 year ago

@phoerious how

phoerious commented 1 year ago

It contains additional files needed for building proper release builds.