search

keepcalm / BukkitForge

The world's first __opensource__ coremod. Also a port of the Bukkit server API to MinecraftForge.
http://www.minecraftforge.net/forum/index.php/topic,3254.0.html
103 stars 60 forks source link

[Base-BlockBreaking] entity items bypass blockbreak event #249

Open soulgriever opened 11 years ago

soulgriever commented 11 years ago

currently as it stands, items such as mining lasers, quarrys, turtles bypass plugins like residence, anyway to stop this, also tnt and nukes bypass the block break events too, mcport team uses a fake player, perhaps have a look at their code?

AeroEden commented 11 years ago

Yea its because the mod developers haven't added in a block break advent :( I would go and ask them to implement block breaks by using a FakePlayer. Also the maker of BukkitForge is working on it too.

soulgriever commented 11 years ago

well I do know that the porters of the main mods implement this ic2,buildcraft,redpower,computercraft but as for the developers themselves you would think they would pick up on the idea no matter if it is used for bukkit or not

SpoonsJTD commented 11 years ago

Dupe of #145

soulgriever commented 11 years ago

this is not a dupe of #145 a player attempting to break a block can no longer break blocks, this is if an entity is used to break a block it still bypasses the block break event, It is not even registerd by any listeners, now I can understand if you want to merge all block break events into one issue, but these are completly diffrent issues with block break event

also as of build 60 this is not fixed

SpoonsJTD commented 11 years ago

Not dupe, sorry.

cheekyvimto commented 11 years ago

As of Build 80 this is not yet fixed, to confirm (Towny Advance 0.82.0.0, works correctly, it automatically adds the FakePlayer permissions as part of the plugin, obviously the feature is not implemented yet) However I also realise this feature was added directly to the mods during porting for MCPC, perhaps we can implement an a method without having to port the mods especially? (Perhaps lifting the blockbreaking method they use, and add it as an additional permission type?)

cheekyvimto commented 11 years ago

Also found this, which may help with above? http://www.minecraftforum.net/topic/1650110-mytown-aperf-server-protection-and-performance-mods/

soulgriever commented 11 years ago

as of build 190 this is still an issue

tonnic commented 11 years ago

This is our main concern for griefing. Ic2 machines and lasers, thaumcraft items, some other mod items. Hoping to get an update on this.