search

keephq / helm-charts

Charts for Keep https://github.com/keephq/keep
MIT License
7 stars 7 forks source link

[BUG]: Can't use PSQL database as an option because of hardcoded mysql db test #10

Closed jackrh closed 6 months ago

jackrh commented 6 months ago

Description of the bug

While you can override the connection string and Keep will now succesfully create and use a PSQL DB it will never connect on the backend unless you override or remove the init container check for mysql.

This line here has a hard coded value for DB name and port (mysql) command: ['sh', '-c', 'until nc -z keep-database 3306; do sleep 1; done;']

Steps To Reproduce

  1. Configure keep-backend to use PSQL DB Connection string
  2. Observe keep-backend init container hangs trying to connect to non existent mysql database.

Additional Information

No response

shahargl commented 6 months ago

solved by https://github.com/keephq/helm-charts/pull/14

jack-hyde-wk commented 6 months ago

That worked, thanks!

shahargl commented 6 months ago

https://github.com/keephq/helm-charts/pull/14