keephq / keep

The open-source alert management and AIOps platform
https://platform.keephq.dev
Other
3.29k stars 275 forks source link

Optimize UI for smaller screens #1220

Closed Matvey-Kuk closed 1 month ago

Matvey-Kuk commented 3 months ago

Please don't assign to yourself if you are not going through the interview process:

We are hiring at Keep, and one of the stages in our hiring process is a test task. To make working on a test task more fun, we ask candidates to take any issue from our public GitHub. We also assign a small bounty to thank candidates for their time. Issues with the bounty are popular, so this particular issue is "held" for candidates going through the interview process. Btw, check our open positions if you want to work at Keep! https://www.ycombinator.com/companies/keep

Currently, Keep's UI is optimized for larger screens only. This issue is a series of minor frontend issues I'm facing as a MacBook (13-inch display) user. Take it if you would like to demonstrate UI skills. I'm pretty sure I didn't catch all of the issues ;)

1) Margins in the list of Providers (and even overflow for some items):

Screenshot 2024-06-09 at 15 47 22

2) Overflow:

Screenshot 2024-06-09 at 15 48 19

3) Margins on the bottom of the Provider configuration page:

Screenshot 2024-06-09 at 15 48 48

4) Give me more space!

Screenshot 2024-06-09 at 15 53 32

5) Too vertical ;)

Screenshot 2024-06-09 at 15 54 28
Matvey-Kuk commented 3 months ago

/bounty 20

algora-pbc[bot] commented 3 months ago

@p1kalys: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

srikary12 commented 3 months ago

I'll be working on this if not @p1kalys

asr2003 commented 3 months ago

@Matvey-Kuk Can it be assigned to me?

/attempt https://github.com/keephq/keep/issues/1220

algora-pbc[bot] commented 3 months ago

@asr2003: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

srikary12 commented 3 months ago

@Matvey-Kuk Can you assign it to me?

srikary12 commented 3 months ago

/attempt #1220

algora-pbc[bot] commented 3 months ago

@srikary12: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

Matvey-Kuk commented 3 months ago

Hi @srikary12, I can't match your account with anyone interviewing for Keep's engineering position. Please reach out to me in DM!

srikary12 commented 3 months ago

The required changes are made in the PR

hrshkshri commented 3 months ago

/attempt #1220

Algora profile Completed bounties Tech Active attempts Options
@hrshkshri 1 bounty from 1 project
JavaScript, C,
Python & more
Cancel attempt
algora-pbc[bot] commented 3 months ago

@hrshkshri: The Keep (YC W23) team prefers to assign a single contributor to the issue rather than let anyone attempt it right away. We recommend waiting for a confirmation from a member before getting started.

Matvey-Kuk commented 3 months ago

Hi @hrshkshri, I can't match your account with anyone interviewing for Keep's engineering position. Please reach out to me in DM!

hrshkshri commented 3 months ago

Hi @hrshkshri, I can't match your account with anyone interviewing for Keep's engineering position. Please reach out to me in DM!

Hello there... Dropped a message

algora-pbc[bot] commented 3 months ago

đź’ˇ @srikary12 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

shahargl commented 3 months ago

@Matvey-Kuk @talboren - workflows page looks bad on small screen: CleanShot 2024-06-24 at 09 05 20@2x

Kiryous commented 2 months ago

Hey, @Matvey-Kuk, I'm coming back with a small PR to fix the issues described—#1491. Please have a look when you have time.

Matvey-Kuk commented 2 months ago

/bounty 75

Kiryous commented 1 month ago