keephq / keep

The open-source alert management and AIOps platform
https://platform.keephq.dev
Other
3.21k stars 238 forks source link

[🐛 Bug] `workflowexecution` result fails when result contains datetime #1255

Open talboren opened 2 months ago

talboren commented 2 months ago

Describe the bug When the result of a workflow execution might include datetime object, we're unable to save it in to the database because of a serialization problem.

To Reproduce

  1. TBD

Expected behavior Workflow result should be saved in the DB properly.

Screenshots CleanShot 2024-06-19 at 12 04 33

Additional context

ArtArtem commented 1 month ago

@talboren @Matvey-Kuk Hi, I probably found the cause of the bug, check it out https://github.com/keephq/keep/pull/1382

ArtArtem commented 1 month ago

@talboren After further exploring the capabilities of SQLAlchemy, I found a more correct way to solve the problem, I'm sure it's better now https://github.com/keephq/keep/pull/1392