keephq / keep

The open-source alert management and AIOps platform

https://platform.keephq.dev

Other

3.25k stars 262 forks source link

feat: Implemented ServiceNow provider to fetch and ingest incidents into Keep #1302

Closed Anshgrover23 closed 3 months ago

Anshgrover23 commented 3 months ago

/claim #1261

Description

This PR introduces a new provider for integrating ServiceNow's ITSM incidents into Keep. It fetches incidents using the ServiceNow Table API and ingests them into Keep as events.

Fixes

Fixes #1261

Changes Made

Implemented ServiceNowProvider class to handle authentication and data retrieval.
Added functions to fetch incidents from ServiceNow and transform them into Keep events.
Updated README.md with setup instructions and usage examples.

Testing

Added unit tests for ServiceNowProvider to ensure proper data retrieval and transformation.
Ran tests locally to verify functionality.

Additional Notes

ServiceNow API integration is complex; detailed documentation is provided to assist future maintenance.

vercel[bot] commented 3 months ago

@Anshgrover23 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant commented 3 months ago

All committers have signed the CLA.

Anshgrover23 commented 3 months ago

@unworld11 what's your problem mam? Even you have chatgpt the problem I think you are more of jealous than solving the issue because I have taken your attempt of bounty you are getting jealous. I am waiting for the maintainer to reply not you.

unworld11 commented 3 months ago

your code is incomplete ansh. i am literally helping you, you can crosscheck your code and the function i am talking about, i don't mind the claim. just making sure yk how open source works, it's barely about the bounty.

buildinpublic :)

Anshgrover23 commented 3 months ago

@unworld11 sorry bro, if you want you can take bounty. I am new to open source I don't know about these and I will take your advice politely and thanks for helping me brother. And sorry for my comment

shahargl commented 3 months ago

@Anshgrover23 hey bro, why did you remove all the comments from the code? it is very hard to understand what are the real code changes and what are not. Can you revert these changes so I'll be able to review only relevant code?

Anshgrover23 commented 3 months ago

@shahargl i am doing undone the comments

Anshgrover23 commented 3 months ago

@shahargl check done reapplied all the comments removed by mistake

shahargl commented 3 months ago

Closing until @Anshgrover23 will have end to end working.