keephq / keep

The open-source alert management and AIOps platform
https://keephq.dev
Other
4.97k stars 702 forks source link

[🔨 Enhancement]: Secrets Manager - add error handling and exceptions #1425

Open shahargl opened 4 months ago

shahargl commented 4 months ago

Current:

  1. BaseSecretManager - read_secret, write_secret as abstract methods
  2. Every deriving manager implements those functions
  3. No error handling

Expected Behaviour

  1. BaseSecretManager - _read_secret, _write_secret as abstract methods
  2. BaseSecretManager - read_secret and writesecret which uses the `` methods with try/except
  3. Every deriving manager implements error handling with at least PermissionError
PRIYANKjakharia commented 1 month ago

i can work on this