keephq / keep

The open-source alert management and AIOps platform
https://keephq.dev
Other
3.94k stars 330 forks source link

[➕ Feature]: Improve workflow validation #1885

Open shahargl opened 1 month ago

shahargl commented 1 month ago
  1. Today "id" is being used as an name. This behavior should be deprecated. If an id is supplied, use it, and use name as name https://github.com/keephq/keep/blob/main/keep/parser/parser.py#L37
  2. Deleting an workflow and creating another workflow with the same name shows again all old data since deleting a workflow make it is_deleted=1 and not really deletes the workflow (which is ok). Uploading a workflow without an id should generated different uuid.
  3. Improve validation - mark workflow with some flag that says it won't run (e.g. configuration error) until something will fix it
rajeshj11 commented 1 month ago

@shahargl I would like to work on this. can you please guide me on what are the improvements we need?

shahargl commented 1 month ago

@rajeshj11 yes! updated ticket.

rajeshj11 commented 1 month ago

@shahargl Can we create two identical workflows?

shahargl commented 1 month ago

/bounty 50

algora-pbc[bot] commented 1 month ago

💎 $50 bounty • Keep (YC W23)

Steps to solve:

  1. Start working: Comment /attempt #1885 with your implementation plan
  2. Submit work: Create a pull request including /claim #1885 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to keephq/keep!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @rajeshj11 Sep 19, 2024, 12:29:08 PM WIP
🟢 @35C4n0r Sep 24, 2024, 1:32:27 PM #2013
rajeshj11 commented 1 month ago

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@rajeshj11    3 keephq bounties
+ 16 bounties from 7 projects
JavaScript, TypeScript,
HTML
Cancel attempt
35C4n0r commented 3 weeks ago

@Matvey-Kuk is anyone working on this currently? I would like to attempt it.

Matvey-Kuk commented 3 weeks ago

@35C4n0r it's yours!

35C4n0r commented 3 weeks ago

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options
@35C4n0r    18 keephq bounties
+ 12 bounties from 4 projects
Python, TypeScript,
HTML & more
﹟1771
Cancel attempt
rajeshj11 commented 3 weeks ago

/attempt #1885

Algora profile Completed bounties Tech Active attempts Options @35C4n0r    18 keephq bounties

  • 12 bounties from 4 projects Python, TypeScript, HTML & more ﹟1771 Cancel attempt

@35C4n0r I have already attempted the issue, and although I wasn't able to get my changes merged, I do have some context on the modifications. If needed any assistance on this feature. feel free to reach out to me. I am open to collaborate

talboren commented 3 weeks ago

Can you please give this PR a better indicative name? 🙏🏼

Matvey-Kuk commented 6 days ago

Payout for this bounty will be executed via GitHub Sponsors, not via Algora. Please activate https://github.com/sponsors/accounts for your account to receive the payout, sorry for the inconvenience