search

keepkey / keepkey-desktop

KeepKey Desktop Application
https://keepkey.com
GNU General Public License v3.0
6 stars 5 forks source link

(WALLET_CONNECT) Tokenlaunch figured out how to crash the app. #549

Closed BitHighlander closed 1 year ago

BitHighlander commented 1 year ago

recreate

go to dapp https://tokenlauncher.com/

type in token info

BitHighlander commented 1 year ago

see crash on submit

BitHighlander commented 1 year ago

TODO handle an empty TO address for contract creation

mrnerdhair commented 1 year ago

As best I can tell, this occurs on the tokenlauncher side as it's serializing the walletconnect request but before it sends it over the pipe. I've added some pretty deep logging hooks which should catch any event coming in from the client app very early in the process, certainly before we have a chance to hand it to hdwallet-keepkey-rest or keepkey-sdk or anything else that might be capable of producing the error on our side, but nothing's triggering at all (other than the normal pair procedure) before the failure. It looks to me like an issue with tokenlauncher and walletconnect in general?

mrnerdhair commented 1 year ago

confirmed -- same error triggers when using walletconnect to the trust wallet ios app

mrnerdhair commented 1 year ago

(for reference, this doesn't crash our app -- the toast style they use looks a lot like ours though)