keepkey / keepkey-firmware

KeepKey Device Firmware
GNU Lesser General Public License v3.0
152 stars 102 forks source link

Add segwit xpub magic for litecoin and digibyte #317

Open kaladinlight opened 2 years ago

kaladinlight commented 2 years ago

There is currently no sewgit_p2sh or segwit_native xpub magic enabled for litecoin and digibyte resulting in the inability to get public keys in the correct format using the corresponding coin name.

Update https://github.com/keepkey/keepkey-firmware/blob/master/include/keepkey/firmware/coins.def to support the following:

I am not familiar enough with the firmware to know if there would be any additional fallout by enabling or if it would just follow the same code paths as bitcoin which does have them enabled already...

markrypt0 commented 2 years ago

I verified the magic numbers and will include this in the next release which should happen today or tomorrow.