keepright / keepright

Data Consistency Checks for openstreetmap.org
http://keepright.at
38 stars 11 forks source link

Correct crossbreeding character × for key species #80

Open PanderMusubi opened 7 years ago

PanderMusubi commented 7 years ago

Nodes with natural=tree can have a value for the key species which donates the species of the mapped tree. Sometimes, the species is crossbred and the value is a concatenation of two names separated with a × character (with spaces on either side of that character). This character is U+00D7 or the MULTIPLICATION SIGN in Unicode.

A good example is https://taginfo.openstreetmap.org/tags/species=Citrus%20%C3%97%20aurantium

However, since not everybody knows that this is not a character x or doesn't know how to enter it, the character x or X is used. Examples of this are https://taginfo.openstreetmap.org/tags/species=Platanus%20x%20hispanica and https://taginfo.openstreetmap.org/tags/species=Platanus%20X%20hispanica

Please add support in keepright in order to easily correct these values, without the user having to enter the × character himself or herself.

PanderMusubi commented 7 years ago

Additionally, this character should not appear in values for teh key genus. Examples which should be fixed manually (probably by changing the key from genus to species).

Examples are https://taginfo.openstreetmap.org/tags/genus=Magnolia%20%C3%97%20soulangeana and https://taginfo.openstreetmap.org/tags/genus=Salix%20sepulcralis%20(%C3%97)%20'Chrysocoma'

PanderMusubi commented 7 years ago

Also, for species no brackets need te be used around the ×. Examples are https://taginfo.openstreetmap.org/tags/species=Tilia%20(x)%20Europaea%20Pallida and https://taginfo.openstreetmap.org/tags/species=Salix%20sepulcralis%20(%C3%97)%20'Chrysocoma'

PanderMusubi commented 7 years ago

Last but not least, a value for species should always start with an upper case character.

PanderMusubi commented 7 years ago

Note that this is not limited to nodes natural=tree and probably applies to all elements with tags species and/or genus.