search

keeps / dbptk-developer

DBPTK Developer - library and command-line tool for execution of database preservation actions
http://www.database-preservation.com
GNU Lesser General Public License v3.0
43 stars 19 forks source link

Build of default profile without Java 8 is broken #605

Closed daniel-skovenborg closed 4 months ago

daniel-skovenborg commented 7 months ago

Because dbptk-bindings has been added to the default Maven profile it can no longer be build with a Java version newer than Java 8. The build fails with:

[ERROR] Failed to execute goal org.jvnet.jaxb2.maven2:maven-jaxb2-plugin:0.12.3:generate (generate-jaxb-siard) on project dbptk-bindings-siard1: Execution generate-jaxb-siard of goal org.jvnet.jaxb2.maven2:maven-jaxb2-plugin:0.12.3:generate failed: A required class was missing while executing org.jvnet.jaxb2.maven2:maven-jaxb2-plugin:0.12.3:generate: com/sun/codemodel/CodeWriter

The dbptk-bindings module should be removed from the default profile again, or DEV_NOTES.md should instruct to install JDK 1.8 and set JAVA_HOME. On Ubuntu:

$ sudo apt install openjdk-8-jdk
$ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 mvn -Dmaven.test.skip clean package
luis100 commented 7 months ago

Instead, dbptk-binding should be made compatible with Java 9+ even if dropping compatibility with Java 8.

daniel-skovenborg commented 7 months ago

I agree, I just felt that was too much to ask :-)

daniel-skovenborg commented 4 months ago

I can confirm that the issue is solved. Sorry if I interrupted your workflow by clicking the Close button, I should probably have just commented instead.

luis100 commented 4 months ago

No worries. Heads up we are upgrading DBPTK Java to 21 across sub-projects, libraries and tools.