keeps / dbptk-ui

DBPTK base UI for both Desktop and Enterprise
https://database-preservation.com
GNU Lesser General Public License v3.0
23 stars 9 forks source link

ui save search - cancel button works unexpectedly #284

Closed Laurira closed 3 years ago

Laurira commented 3 years ago

This is very low priority issue.

  1. In the beginning of this test I have zero "Saved searches" image
  2. Now I click on table Sakila -> actor, then I click "advanced" and then I click "SAVE SEARCH". Next from is displayed: image
  3. Now when I click "CANCEL" then I will be redirected on my searches and this search is still saved: image

I think the proper behavior would be that user will be directed to previous display (table actor) and no search is saved. Currently search is saved at the moment when user clicked "SAVE SEARCH" no matter what user will click next.

hmiguim commented 3 years ago

Fixed released on https://github.com/keeps/dbptk-ui/releases/tag/v2.5.6