keeps / roda

RODA - Repository of Authentic Digital Objects
https://www.roda-community.org/
GNU Lesser General Public License v3.0
74 stars 48 forks source link

CAS on/off filters should share common settings #660

Closed jmaferreira closed 7 years ago

jmaferreira commented 8 years ago

The goal is to simplify the roda-wui.properties

Suggestion: Activate via parameters on the web.xml that would set the settings prefix.

rui-castro commented 7 years ago

@jmaferreira @hsilva-keep @luis100 done in PR #698

Configuration on roda-wui.properties changed to this form:

##############################################
# Internal filters
##############################################

ui.filter.internal.enabled = false
ui.filter.internal.realm = RODA REST API
ui.filter.internal.exclusions = ^/swagger.json,^/v1/theme/?

##############################################
# CAS filters
##############################################

ui.filter.cas.enabled = true
ui.filter.cas.casServerUrlPrefix = https://localhost:8443/cas
ui.filter.cas.casServerLoginUrl = https://localhost:8443/cas/login
ui.filter.cas.exclusions = ^/swagger.json,^/v1/theme/?,^/v1/auth/ticket?
# RODA base address
ui.filter.cas.serverName = http://localhost:8888
ui.filter.cas.exceptionOnValidationFailure = false
ui.filter.cas.redirectAfterValidation = false

In web.xml the parameter config-prefix was added to all filters. Like these:

<filter>
    <filter-name>InternalWebAuthFilter</filter-name>
    <filter-class>org.roda.wui.filter.OnOffFilter</filter-class>
    <init-param>
        <param-name>inner-filter-class</param-name>
        <param-value>org.roda.wui.filter.InternalWebAuthFilter</param-value>
    </init-param>
    <init-param>
        <param-name>config-prefix</param-name>
        <param-value>ui.filter.internal</param-value>
    </init-param>
</filter>
<filter>
    <filter-name>CASAuthenticationFilter</filter-name>
    <filter-class>org.roda.wui.filter.OnOffFilter</filter-class>
    <init-param>
        <param-name>inner-filter-class</param-name>
        <param-value>org.jasig.cas.client.authentication.AuthenticationFilter</param-value>
    </init-param>
    <init-param>
        <param-name>config-prefix</param-name>
        <param-value>ui.filter.cas</param-value>
    </init-param>
    <!-- ... -->
</filter>
luis100 commented 7 years ago

Checked and merged into lf_dev at 2f5f819a66c6ee90954bb430b2845beeca4621c4