keepsuit / laravel-zoho-campaigns

Manage Zoho Campaigns from Laravel
MIT License
1 stars 1 forks source link

Incorect installation instructions or bug during installation. #14

Closed andreibaca closed 9 months ago

andreibaca commented 9 months ago

The readme file suggests to publish the migration before running artisan migrate.

php artisan vendor:publish --tag="campaigns-migrations"
php artisan migrate

but in the service provider class CampaignsServiceProvider the configurePackage method already instructs the application to run the migration from the vendor folder.

    {
        $package
            ->name('campaigns')
            ->hasConfigFile()
            ->hasMigrations([
                'create_zoho_campaigns_tokens_table',
            ])
            ->runsMigrations()
            ->hasCommands([
                SetupCommand::class,
            ]);
    }

which results in double migration attempt and failing the second migration.

cappuc commented 9 months ago

Fixed in v0.2