Button style primary and secondary options might be ordered wrong? 😝

keepthatworktoyourself / wombat

Not another website builder. Public repo — raise issues, request features, get help.

2 stars 0 forks source link

Button style primary and secondary options might be ordered wrong? 😝 #43

Closed bhallstein closed 2 years ago

bhallstein commented 2 years ago

Screenshot 2022-05-06 at 16 14 29

Sorry if this is terribly trivial just seemed odd to me. Maybe intentional?

pjrundle commented 2 years ago

Don't feel particularly strongly either way. Will probably look and see if there is an industry standard pattern. Initial thought was to encourage people to use secondary rather than primary everywhere by setting as default and placing in pos 1.

pjrundle commented 2 years ago

Jonna agrees with you 😆

bhallstein commented 2 years ago

Hmm I think the user is going to expect "primary" to come first.

As another option, maybe we should switch to more visual naming. Not sure a primary button vs a secondary button will be meaningful to all users.

bhallstein commented 2 years ago

Resolved in https://github.com/keepthatworktoyourself/wombat-repo/commit/4d486df51c045cb91aa7d076b968bce1f1322bee