search

keero / baseball-streaming

Java CLI application for fetching data from WBSC game data (MyBallClub) and render text and image files on disk.
MIT License
2 stars 1 forks source link

No image for certain players #6

Open molano999 opened 2 months ago

molano999 commented 2 months ago

Hello,

Let me start by saying that I feel bad of having to bother you again. I really love this program and appreciate hugely what you do for baseball/softball, and for us!

I noticed that for "some" players at bat, the player image and team image is not loaded. I double checked on our local wbsc site (baseballsoftball.be) and on the overall stats site (wbsc.org) and the pictures are there. So I am buffled to why some images are not retrieved.

I have this e.g. in game java -jar "C:\OBS_DataDirectory\baseball-streaming-v1.8.1.jar" -m replay -t "C:\OBS_DataDirectory\resources" -s 2024-softball-ladies-d1 -g 133609 -S https://www.baseballsoftball.be/ where (amongst others) the picture of Roxanne Struyf (https://www.wbsc.org/en/player/struyf-roxanne-646956/history) is not loaded. Other players for that game that are not loaded are "Floortje De Ridder" and "Marijke Neerinckx"

I dived in your code, and I think the problem is related to https://github.com/keero/baseball-streaming/blob/6a0eff16c573e7d9d84a8e907a7b3d95363cdf65/src/main/java/org/sundbybergheat/baseballstreaming/services/FilesService.java#L389 , but I could not put my finger on what exactly is wrong... (because I can't fully understand JAVA 😄)

So if you would have some extra spare time to find out what could be wrong, I would appreciate it a lot! But it's not thàt important. ;)

Thank you already!

keero commented 2 months ago

Don't worry about reporting issues. I am happy to receive feedback so i can improve the app. :sunglasses: This is most likely related to the unability to match the series ID against the category ID for the stats (https://github.com/keero/baseball-streaming/issues/5).

enavarrocu commented 1 month ago

Don't worry about reporting issues. I am happy to receive feedback so i can improve the app. 😎 This is most likely related to the unability to match the series ID against the category ID for the stats (#5).

I confirm. That is the issue.

For some players, it works, but not for others. Ex: Works for this one:

Screenshot 2024-05-10 at 00 42 07

But not for this one:

Screenshot 2024-05-10 at 00 43 03

[main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter STRUYF Roxanne (id=385868) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter DE RIDDER Floortje (id=386042) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter NEERINCKX Marijke (id=386304) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter STRUYF Roxanne (id=385868) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter DE RIDDER Floortje (id=386042) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter NEERINCKX Marijke (id=386304) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter HUYBENS Nathan (id=366357) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter BELHALOUMI Maya (id=394750) [main] WARN org.sundbybergheat.baseballstreaming.services.FilesService - No stats for batter BELHALOUMI Maya (id=394750)