search

keesverruijt / BR24radar_pi

OpenCPN radar plugin for Navico Broadband Radars (BR24, 3G, 4G models) [HISTORIC]
17 stars 26 forks source link

Range is km although settings is Nm #233

Closed Hakansv closed 8 years ago

Hakansv commented 8 years ago

Today's fetch. Nice job and good cleaned - neither warnings nor errors. Although I've tested trails_performance I'll make live test tomorrow.

The range unit is km while settings is NM br24_unit

douwefokkema commented 8 years ago

I can't reproduce this issue yet....I will check the code.

Hakansv commented 8 years ago

Douwe. You couldn't. - Hmmm - I'm at home using emulator, could that be the cause. I'll check on board tomorrow.

keesverruijt commented 8 years ago

This could be related to difference between 4g and br24. The code needs to take the distance in decimeters sent by the radar and map that back to a range, it uses a double lookup but this does depend on it being able to find the exact value right now. This was done so that if you set O to meters but the plotter to NM or viceversa and then let the non O product set a range that the plugin reflects the range selected on that other product. I think this is not the right decision actually.

Sent from my iPhone

On 26 Sep 2016, at 21:34, Håkan Svensson notifications@github.com wrote:

Douwe. You couldn't. - Hmmm - I'm at home using emulator, could that be the cause. I'll check on board tomorrow.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Hakansv commented 8 years ago

This was a simulation, emulator, problem only. Not an issue using a real BR24 radar.