AISinARPA as vector to save space and avoid possible restriction in n…

Hakansv commented 6 years ago

…umber of targets.

Kees.

This change is made for three reasons:

A vector array is not defined from start and thus takes not more memory then needed.
The array size is not limited and thus always big enough.
Third and not less; My first lesson on using struct - vector so combined with the above features it was fun. BUT - Please check if vectors like this is able to use in our plugin. The #include is not used before. Is there a reason for that? I've built and run it on Win10. It's built and run on Linux/Rasbian but I've no OSX so not tested there. Your comments/criticism are very welcome and if this change is not feasible please do not merge it. Instead I'll appreciate your experienced advice. Håkan

keesverruijt commented 6 years ago

Håkan,

Looking good to me.

I have only one remark — the new vector member name is better if it is in line with our guidelines for member names, so m_ais_in_arpa_zone instead of AISinARPAzone.

Can you update your pull request accordingly (just add a commit to your branch AISVector)

Hakansv commented 6 years ago

Kees. The PR's updated hopefully according to your intention. Håkan

keesverruijt / BR24radar_pi

AISinARPA as vector to save space and avoid possible restriction in n… #294