search

keeweb / kdbxweb

Web Kdbx library
https://app.keeweb.info
MIT License
413 stars 57 forks source link

Key encryptor promise interface #10

Closed Strikeskids closed 8 years ago

Strikeskids commented 8 years ago

Using promises instead of callbacks throughout KeyEncryptor maintains code style more effectively. It centralizes error-handling logic so that the program flow is easier to understand. Also, it has hardly any impact on other parts of the application, because callbacks can be translate to promises with a 5 character change.

I understand this change could be construed as opinionated, so I'm not 100% confident in it being merged.

antelle commented 8 years ago

Nope. We are not going to add any additional dependency only for syntactic sugar.