search

keeweb / keeweb-connect

Browser extension for KeeWeb
MIT License
93 stars 13 forks source link

Bump node to 18 #57

Closed HarlemSquirrel closed 4 months ago

HarlemSquirrel commented 4 months ago

Was able to build and install locally but so far unable to connect to KeeWeb from extension when built from this branch.

HarlemSquirrel commented 4 months ago

Well for some reason tonight when I rebuilt it now it's working :sweat_smile:

Aetherinox commented 4 months ago

Got to love when that happens. FYI, as of today's changes, ensure your environment uses only one of the following NodeJS versions:

If KeeWeb is built on any other version; there will be dependency errors and things will break. I'm running on v22 and focusing the builds around that for the simple fact of v22 getting require()ing ES modules. But NodejS LTS 20 works just as well.

Is this PR completely done now?

HarlemSquirrel commented 4 months ago

I'd like to test the chrome extension but haven't yet. That's it

HarlemSquirrel commented 4 months ago

Having trouble connecting to Chrome with local built extension. I think it may be due to the extension ID being different but updating https://github.com/keeweb/keeweb/blob/master/desktop/scripts/const/extension-ids.js and running keeweb locally doesn't solve it for me.

HarlemSquirrel commented 4 months ago

Still not working with node 16 or 18 on master branch, last tag, or this branch. I'm clearly missing something.

HarlemSquirrel commented 4 months ago

@antelle sorry to bug you but do you have any thoughts on what I might be missing here running chrome/chromium extension locally and connecting to keeweb desktop? Firefox works but in Chromium I get no logs in the desktop console which leads me to believe it's not receiving any messages at all. The background extension console says KeeWeb host disconnected Specified native messaging host not found.

antelle commented 4 months ago

Do you have the messaging host config enabled? When you check the checkbox in settings in KeeWeb, it creates the config, but I assume it has a wrong extension ID there

HarlemSquirrel commented 4 months ago

OK I'm not sure why but I got it working on a different computer running Pop OS 22.04 so I'm going to say this is working OK with Firefox and Chrome.

HarlemSquirrel commented 4 months ago

I also successfully tested edge

Aetherinox commented 4 months ago

Did you get all of it working now? I still need to mess with this to get a feel for it. But I'll have to do it after I finish up the stuff with KeeWeb. Don't want to start flip-flopping.

You can merge this whenever you feel it's fully done, you've got more experience with this aspect, so I'll trust your judgement. I just wanted to make sure we start getting packages updated so we can work with the latest.

HarlemSquirrel commented 4 months ago

Yeah it's working locally. There does appear to be a validation issue when trying to publish the Firefox addon but I have a separate PR for that

Aetherinox commented 4 months ago

NIce, progress. I'll definitely look into these plugins after I wrap up my end. I spend half my time reading pages of code so that I know what all is done in that segment, trying to get myself familiarized with this app like I would my own. Mainly prepping myself for the Electron v14+ migration since a lot has changed, and I don't want ti keep us running on v13 for too long.

I've looked at the future versions, and once we make ourselves compat with 14, we can easily bump up to v20 before there's any other major changes to do. Just minor API changes in-between.