kefaslungu / resourceMonitor

Resource Monitor add-on for NVDA
GNU General Public License v2.0
13 stars 18 forks source link

Add-on release: edit buildVars.py instead of manifest.ini.tpl #15

Closed josephsl closed 1 year ago

josephsl commented 1 year ago

Hi all,

There appears to be a critical showstopper happening with Resource Monitor 23.04.x release process, traced to a commit that edited manifest.ini.tpl file. The manifest.ini.tpl file is a template file that comes from add-on template and should not be edited by hand. When defining new releases and authors, buildVars.py must be edited. This may also explain why version 23.04 release page is suddenly showing something called 23.0.4 instead of 23.04 as download package name, causing tools such as Add-on Updater to report errors wen downloading the new package.

I advise:

  1. Revert the commit that edited manifest.ini.tpl.
  2. Ask NV Access to close any Resource Monitor related issues and pull requests on add-on datastore repository.
  3. Remove 23.04 and 23.0.4 from add-on datastore.
  4. Regenerate 23.04 or 23.04.1 version and submit it to add-on datastore. When regenerating, use ad-on template/SCons.

Notes:

  1. Do not close add-on datastore submission issue by hand until the pull request that will be created based on the submission is merged to datastore master branch.
  2. When possible, use SCons to build the add-on package rather than zipping it by hand.

Thanks.