search

kefirfromperm / grails-asynchronous-mail

The Grails Asynchronous Mail plugin
http://grails.org/plugin/asynchronous-mail
21 stars 36 forks source link

ExpiredMessagesCollectorJob should not contain any SQL #12

Closed stokito closed 11 years ago

stokito commented 11 years ago

ExpiredMessagesCollectorJob updates AsynchronousMailMessage table. It looks for me not a good idea. There is a convention that all changes to DB should be done by service. Could you extract this code to method in AsynchronousMailPersistenceService class?

stokito commented 11 years ago

I found your commit https://github.com/kefirfromperm/grails-asynchronous-mail/commit/992c06a971e74f343ff67f2453921b1d25c02fa2 that fix problem. Thanks!