search

kefirjs / kefir

A Reactive Programming library for JavaScript
https://kefirjs.github.io/kefir/
MIT License
1.87k stars 97 forks source link

`.bufferBy` should emit empty array if buffer is empty (now just don't emit) #108

Closed rpominov closed 9 years ago

rpominov commented 9 years ago

For consistency, and for the cases like https://gitter.im/pozadi/kefir?at=5571f18227d2203776ccc293

rpominov commented 9 years ago

Not sure if it a breaking change improvement or a bug fix. I prefer latter.

shamansir commented 9 years ago

Great, thank you!

rpominov commented 9 years ago

For those who by chance was affected by the fix in a bad way, you should add .filter(arr => arr.length > 0) after .bufferBy().

@shamansir No problem!