kefirjs / kefir

A Reactive Programming library for JavaScript
https://kefirjs.github.io/kefir/
MIT License
1.87k stars 97 forks source link

Deprecations warnings disable API is broken #185

Closed rpominov closed 8 years ago

rpominov commented 8 years ago

After we switched to Rollup, we've accidentally broken the warnings disabling feature. It worked like this:

const kefir = require('kefir')
Kefir.DEPRECATION_WARNINGS = false

Not sure if this API can be preserved with Rollup, maybe we'll need to switch to something like the following in order to fix this:

const kefir = require('kefir')
Kefir.disableDeprecationWarnings()
Kefir.enableDeprecationWarnings()
rvikmanis commented 8 years ago

Hope this is not super critical, can do it probably next week.

rpominov commented 8 years ago

Thanks, @rvikmanis. That would be cool. Not critical at all as it seems to me.