search

kefirjs / kefir

A Reactive Programming library for JavaScript
https://kefirjs.github.io/kefir/
MIT License
1.87k stars 97 forks source link

ES Observable's subscribe should return a subscription object #212

Closed acdlite closed 8 years ago

acdlite commented 8 years ago

According to the ES Observable proposal, subscribe should return a subscription object, not an unsubscribe function:

https://github.com/rpominov/kefir/blob/master/src/interop/to-es-observable.js#L22

I'm happy to submit a PR if needed.

rpominov commented 8 years ago

Funny, we've just discovered it here too :smile:

A PR would be great!

rpominov commented 8 years ago

Actually nevermind, I'll fix it quickly myself.

rpominov commented 8 years ago

Should be fixed in 3.2.6