search

kefirjs / kefir

A Reactive Programming library for JavaScript
https://kefirjs.github.io/kefir/
MIT License
1.87k stars 97 forks source link

Maintain TypeScript types? #291

Open mAAdhaTTah opened 5 years ago

mAAdhaTTah commented 5 years ago

We maintain types for Flow, but there are TS types in DefinitelyTyped. I have an open PR to update them, but I'm wondering if maybe it makes more sense to pull them in and maintain them ourselves? It would be easier to then keep the Flow & TS types in sync.

Macil commented 5 years ago

I'm in favor of pulling them in.

We can make our tests sanity check the definitions by adding a tsconfig.json that includes "noEmit": true, adding typescript to devDependencies, and adding && tsc to package.json's scripts.test.

gamb commented 4 years ago

Any change of decision here or still thinking you'll pull the types in? Happy to help if I can

mAAdhaTTah commented 4 years ago

@gamb I'm still open to it but I haven't had to make changes since the PR I opened in the OP so it hasn't been a high priority. If you want to PR in the types & handle deprecating them in the DT repo, I'd approve it.

gamb commented 4 years ago

@mAAdhaTTah Thanks. I'll try to find some time to put something up 👍