search

keflavich / cube-line-extractor

4 stars 1 forks source link

Clean-up Testing Calculations of Line Width, FWHM, Variance, and Centroid #26

Closed jmangum closed 2 years ago

jmangum commented 2 years ago

Remnant from original development of this application. We calculate width_map, fwhm_map, sqrtmom2_map, and centroid_map but only use width_map and centroid_map for various kinds of masking. Before removing the unused fwhm_map and sqrtmom2_map calculations, wondering which of these width-related images:

(1) width_map (2) fwhm_map (3) sqrtmom2_map

...is the right one to use for width masking?

keflavich commented 2 years ago

they're all equivalent. sqrtmom2=width=fwhm/2.35

jmangum commented 2 years ago

ok. Suggest removing fwhm_map and sqrtmom2_map then and sticking with using width_map for masking.

keflavich commented 2 years ago

could you submit a PR doing that?

jmangum commented 2 years ago

Yes. I am working from a branch at the moment that I thought would address several of these minor "cleanup" issues.

jmangum commented 2 years ago

Resolved with PR #28