keflavich / cube-line-extractor

4 stars 1 forks source link

Allow for multiple sample pixels #38

Closed jmangum closed 2 years ago

jmangum commented 2 years ago

This turned-out to be a messier PR than I had originally intended due to a simple change I made to where the sample_pixel values are processed. The implementation of multiple sample_pixel values was relatively easy. The hard part came in when I moved sample_pixel input from main to cubelinemoment_setup (which is really where I think it belongs). This entailed modifying a lot of function definitions and function calls, along with using 'params.pop('sample_pixel')to recall the processed (turned into pixel coordinates)sample_pixelvalues calculated incubelinemoment_setup. I really don't understand completely why I had to usepop` in this way, but it seems to work. If this PR is approved, I will make another branch and clean-up all the redundant commented calls (unless you think otherwise). Closes #18