search

keflavich / image_registration

Image Registration for Astronomy
MIT License
156 stars 53 forks source link

FITS_tools already included #23

Closed juliotux closed 5 years ago

juliotux commented 5 years ago

Hi @keflavich

Why FITS_tools is set as dependecy in the code if it is already included as a sub-folder?

Removing it from the dependencies makes possible to simply create anaconda packages with python setup.py bdist_conda.

keflavich commented 5 years ago

My intent was to completely remove the FITS_tools duplications within this package and instead use the FITS_tools package as a dependency; it looks like I only half-completed that refactor. This package does depend on FITS_tools, but it's a pretty light dependency.

juliotux commented 5 years ago

Thanks @keflavich, I'll keep looking to the image_registration and, if it get updated, I'll pack FITS_tools too. I use it for my pipeline and I'm packing everything in my Anaconda cloud.

keflavich commented 5 years ago

Sounds good. If you want to have a go at refactoring the code further, PRs are welcome, I just don't have the time to do work that isn't strictly necessary for functionality right now