kefranabg / readme-md-generator

πŸ“„ CLI that generates beautiful README.md files
https://www.npmjs.com/package/readme-md-generator
MIT License
10.94k stars 1.37k forks source link

Use npm/yarn #167

Closed kefranabg closed 4 years ago

kefranabg commented 5 years ago

If a package.json is detected, readme-md-generator should ask to choose between yarn and npm. It would allow suggest install, usage and test command with correct package manager (instead of always using npm)

anku255 commented 5 years ago

If you want, I can give it a shot.

kefranabg commented 5 years ago

Sure, feel free to ask question. I suggest you to use inquirer list to let the user choose between npm and yarn

anku255 commented 4 years ago

Hi @kefranabg

This issue can be closed now (#172).

Offtopic: Hey, can you please tell me about changing the author of a git commit while merging a PR such that it looks like user1 authored and user2 commited? And if it is possible to do it on Github itself?

kefranabg commented 4 years ago

Hi @anku255 ,

Offtopic: Hey, can you please tell me about changing the author of a git commit while merging a PR such that it looks like user1 authored and user2 commited? And if it is possible to do it on Github itself?

I don't really understand the question, but I'll try to answer πŸ˜‰The one who merge will always be marked as commiter, but the author owns the contributions on that PR. Also I don't think you can change that behavior on github. Feel free to discuss here even if the issue is closed

anku255 commented 4 years ago

Hey!

I recently became the maintainer of howtographql repo and whenever I merge a PR, it looks like this -

Screenshot 2019-12-02 at 4 15 31 PM

But I want it to be like this -

Screenshot 2019-12-02 at 4 15 48 PM
kefranabg commented 4 years ago

Oh, this is strange. Actually I don't do anything special to get this format: user1 authored and user2 commited I just use the squash and merge button from Github.

anku255 commented 4 years ago

Oh, this is strange. Actually I don't do anything special to get this format: user1 authored and user2 commited I just use the squash and merge button from Github.

Oh, I got it. I guess I need to sqash and merge instead of merge. I will test it. Thank you πŸ˜ƒ