search

keichan34 / exfile-imagemagick

An ImageMagick file processor suite for Exfile
MIT License
7 stars 7 forks source link

Add support for GraphicsMagick #8

Closed cblock closed 6 years ago

cblock commented 6 years ago

Attached please find my initial attempt at integrating GraphicsMagick into the lib as proposed in #7.

Please note that there GraphicsMagick handles EXIF data slightly differently. Instead of providing exif:DateTimeOriginal keys it provides DateTimeOriginal keys. I thus added a little normalization logic that ensures EXIF Data ist always provided in GraphicsMagick format no matter what library is used underneath.

cblock commented 6 years ago

Not quite sure why travis fails. Looks like GM executable cannot be called though graphicsmagick seem to have been installed properly. @keichan34 maybe you have an idea?

cblock commented 6 years ago

@keichan34 Thanks for your code review and the suggestions. I moved the image procesor logic to the GenServer and I also fixed the failing tests in Travis CI.

keichan34 commented 6 years ago

@cblock Looks good! Thanks!