stub empty attachment call + fix phoenix missing use

keichan34 / exfile

File upload persistence and processing for Phoenix / Plug

MIT License

90 stars 19 forks source link

stub empty attachment call + fix phoenix missing use #41

Closed noma4i closed 8 years ago

noma4i commented 8 years ago

in case you loop thru records and one will have empty attachment that should return nil.
phoenix needs explicit call of use Phoenix.HTML otherwise it will not able to attach methods

keichan34 commented 8 years ago

I'll be able to merge this in a bit. Sorry for the delay!

keichan34 commented 8 years ago

Hm. I checked it out, but it looks like the use Phoenix.HTML isn't required? Can you provide a test case that fails when use Phoenix.HTML is absent?

Also, can you add a test case for returning nil when the empty attachment is nil as well?

The tests for the Exfile.Phoenix.Helpers module are located in test/exfile/phoenix/helpers_test.exs

noma4i commented 8 years ago

Will do today.

noma4i commented 8 years ago

@keichan34 yep. Verified that it works w/o explicit call in dev/prod and as release in prod.

asiniy commented 8 years ago

Why 3 commits per on PR?

noma4i commented 8 years ago

I will squash em and create new PR

asiniy commented 8 years ago

@noma4i you are funny, why can't use fixup them and use current PR?