Allow long bit field sequences

keichi / binary-parser

A blazing-fast declarative parser builder for binary data

MIT License

864 stars 134 forks source link

Allow long bit field sequences #203

Closed mohd-akram closed 2 years ago

mohd-akram commented 2 years ago

Fixes #95 Fixes #35 Fixes #29 Fixes #56 Fixes #71 Fixes #160

keichi commented 2 years ago

Thanks @mohd-akram for resolving this longstanding issue! Are you done editing the PR? I noticed you force pushed several times.

mohd-akram commented 2 years ago

Yeah, should be good now, pushes were just satisfying the CI/test/formatting tweaks.

mohd-akram commented 2 years ago

Any update on this?

keichi commented 2 years ago

Apologies for the delay, the changes look good to me. Just to clarify, this does not lift the limitation that the start and end of a bit field sequence have to byte aligned, right?

mohd-akram commented 2 years ago

Yes, it does not.

keichi commented 2 years ago

Thanks for the clarification. I will publish a new release soon.