keichi / binary-parser

A blazing-fast declarative parser builder for binary data
MIT License
857 stars 134 forks source link

Fix source map by uploading entire dist folder with map files and lib folder with source #218

Closed cmdcolin closed 1 year ago

cmdcolin commented 1 year ago

This PR may help with complaints from build systems like webpack 5 and perhaps improve some source maps


WARNING in ../../node_modules/binary-parser/dist/esm/binary_parser.mjs
Module Warning (from ../../node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/home/cdiesh/src/jbrowse-components/node_modules/binary-parser/dist/esm/binary_parser.js.map' file: Error: ENOENT: no such file or directory, open '/home/cdiesh/src/jbrowse-components/node_modules/binary-parser/dist/esm/binary_parser.js.map'

The entire lib and dist folder are used. The dist folder map files are currently not deployed but are referred to by the js files in dist, and the map files, if deployed, would refer to the lib folder. I've made some similar PRs like https://github.com/satya164/react-simple-code-editor/pull/93/files

keichi commented 1 year ago

I've just released a new version including the lib/ directory. Could you try if this problem has been resolved?

cmdcolin commented 1 year ago

no webpack warning now! thanks :)