keifufu / WebNowPlaying-Rainmeter

Rainmeter Adapter for WebNowPlaying
MIT License
81 stars 4 forks source link

Cover Art is not updating from Navidrome #13

Open LIONSEATLIONS opened 9 months ago

LIONSEATLIONS commented 9 months ago

I'm using v2.0.7 and the cover art doesn't update when listening from Navidrome, is just uses the last updated one. It updates just fine from other sources (Yandex Music for example)

LIONSEATLIONS commented 9 months ago

FYI Navidrome didn't update since February

keifufu commented 9 months ago

I haven't had any problems with Navidrome, I've been using it for all my music since you recommended adding support for it :3

So (assuming you're using rainmeter), this is likely an issue with the skin, although if it works fine with other players I guess it wouldn't be.

LIONSEATLIONS commented 9 months ago

I haven't had any problems with Navidrome, I've been using it for all my music since you recommended adding support for it :3

So (assuming you're using rainmeter), this is likely an issue with the skin, although if it works fine with other players I guess it wouldn't be.

Glad to hear that you're enjoying Navidrome :)

Just figured out that it's working with the demo server but not my own server for some reason. It's strange since i didn't update my server at all since February)

keifufu commented 9 months ago

I get the album cover using the MediaSession api. You can check if it's properly set by pasting navigator.mediaSession.metadata in your console.

LIONSEATLIONS commented 9 months ago

appreciate it, I'll try checking it

LIONSEATLIONS commented 9 months ago

it seems like MediaSession is working, it's the same comparing to the demo. All links working fine image

keifufu commented 9 months ago

Since you're using Firefox, make sure to give the extension full permissions as described here.

LIONSEATLIONS commented 9 months ago

already checked and also tried Edge as well, not the case

keifufu commented 9 months ago

Weird. Are you sure it's only the cover not being reported? The title and artist could be pulled from Native APIs.

LIONSEATLIONS commented 9 months ago

unchecked Use Natives APIs and reconnected the extension. Everything except the cover loads

keifufu commented 9 months ago

I've got no clue and sadly no time to debug this right now. You can try asking for help on the rainmeter discord.

LIONSEATLIONS commented 9 months ago

I really appreciate your help, I'll try to debug something myself tomorrow, maybe it's something wrong on my server or my machine. I'll write back if i find something

LIONSEATLIONS commented 9 months ago

a little update on the situation

using logging in Rainmeter i noticed this error image

Seems like the plugin can parse the link successfully but somehow cannot download the image (the link is working just fine)

Here is an example link to the cover

I had the same issue on two different machines, Windows 11 and Windows 10 and tried clean Rainmeter installation.

I also tried using custom Rainmeter skin to download the image (using the WebParsing plugin) and i succeeded

keifufu commented 9 months ago

Please enable debug logs in rainmeter and copy the debug log here.

LIONSEATLIONS commented 9 months ago

ERRO (22:55:05.494) : WebNowPlaying.dll - Unexpected error downloading https://mtuci.space/playbeck/rest/getCoverArt?u=kevin_sheets&t=255a43acac7f784c785a94029a751c23&s=5710e5&f=json&v=1.8.0&c=NavidromeUI&id=mf-c6f72bc483ece2af7a1c7d666bcae2e8&_=2023-09-18T04%3A48%3A00.052Z&size=300

DBUG (22:55:05.496) : WebNowPlaying.dll - Error Trace: System.AggregateException: One or more errors occurred. ---> System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The request was aborted: Could not create SSL/TLS secure channel. at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult) at System.Net.Http.HttpClientHandler.GetResponseCallback(IAsyncResult ar) --- End of inner exception stack trace --- --- End of inner exception stack trace --- at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at WebNowPlaying.Measure.DownloadImageThread(String CoverUrl) ---> (Inner Exception #0) System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The request was aborted: Could not create SSL/TLS secure channel. at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult) at System.Net.Http.HttpClientHandler.GetResponseCallback(IAsyncResult ar) --- End of inner exception stack trace ---<---

keifufu commented 9 months ago

Thanks, I'll look into this soon.

keifufu commented 4 months ago

Is this issue still occurring? If so, it might be related to you using HTTP/3.

keifufu commented 3 weeks ago

I do not plan to fix this. If rewritten using keifufu/WebNowPlaying-Library then this issue would be resolved but I have no plans of doing so as of now.

Fixing this without a rewrite is also possible, feel free to create a PR.

keifufu commented 1 week ago

wip