search

keifufu / WebNowPlaying-Rainmeter

Rainmeter Adapter for WebNowPlaying
MIT License
100 stars 4 forks source link

Song rating not working #9

Closed Rekushia closed 1 year ago

Rekushia commented 1 year ago

Hi, i've noticed that the song rating funtion doesn't seem to work. It neither shows the current rating, nor can you change it with !ToggleThumbsUp/Down and !SetRating. Rainmeter also shows that the range for the MeasureRating is from 0 to 1.

I've also encountered another problem. I'm not sure if i should describe it here or create a new issue, but it's regarding the album art.

keifufu commented 1 year ago

With what player? Also describe the album art issue here.

Rekushia commented 1 year ago

I've tested it with spotify/spicetify and tidal player, and youtube website.

Regarding the album art issue. When having 2 players "open", the album art doesn't switch properly. For example, when i watch something on youtube, the thumbnail shows properly, but if i pause, and play something on spotify, the thumbnail still shows that youtube video (and vice versa). Title, artist and other playback info and controls work fine.

keifufu commented 1 year ago

I'll see about the album art issue once I have some time to debug it. As for rating, native players (Spotify Desktop, Tidal) don't support rating, only websites do.

Rekushia commented 1 year ago

Also, the skin remembers the last image it used, and displays that even after refresh or pc restart, but i guess that could be solved by removing the content of the WNP temp folder on initial launch.

keifufu commented 1 year ago

Also, the skin remembers the last image it used, and displays that even after refresh or pc restart, but i guess that could be solved by removing the content of the WNP temp folder on initial launch.

For native players I think so, yes.

Rekushia commented 1 year ago

I'll see about the album art issue once I have some time to debug it. As for rating, native players (Spotify Desktop, Tidal) don't support rating, only websites do.

See, this is weird, as it worked for me last week. I might've used a different version of the WNP plugin i guess?. It stopped working when i installed the WNP browser extension and it prompted me to update the plugin.

keifufu commented 1 year ago

I'll see about the album art issue once I have some time to debug it. As for rating, native players (Spotify Desktop, Tidal) don't support rating, only websites do.

See, this is weird, as it worked for me last week. I might've used a different version of the WNP plugin i guess?. It stopped working when i installed the WNP browser extension and it prompted me to update the plugin.

Spicetify is not supported as of right now. With WNP 2.0.0 and newer, native players are supported out of the box, however due to the Windows API it's impossible to interact with rating and volume.

I honestly recommend using web players if you're someone to have a browser open all the time anyway.

Rekushia commented 1 year ago

I've just checked, the rating doesn't seem to work on spotify web player either.

keifufu commented 1 year ago

I've just checked, the rating doesn't seem to work on spotify web player either.

It should be able to read it but not change it. Spotify changed their css (as they do every 7 minutes) which broke it (I haven't bothered to update the extension yet)

Rekushia commented 1 year ago

Unfortunately, it doesn't seem to be able to read it as well. Ehh, it's not like it's a killer, but a "nice to have" thing. For now i'll just hide the like dislike icons from my skin. And thanks for looking into the album art problem. It doesn't seem to be an issue when using the web player, so i'll just use that.

lehuymanhtan commented 1 year ago

I'll see about the album art issue once I have some time to debug it. As for rating, native players (Spotify Desktop, Tidal) don't support rating, only websites do.

See, this is weird, as it worked for me last week. I might've used a different version of the WNP plugin i guess?. It stopped working when i installed the WNP browser extension and it prompted me to update the plugin.

The reason is that the wnp extension comes with Spicetify only supports WNP versions below 2.0.0. So if you still want song rating, you can install the extension called WebNowPlaying-Redux-Spicetify from Spicetify-Marketplace. It should work, even now it's deprecated but it still supports WNP version 2.x.x.

keifufu commented 1 year ago

What? No it doesn't.

lehuymanhtan commented 1 year ago

What? No it doesn't.

ok. It doesn't work if native API is turned on, but it did work if native API is turned off.

image

keifufu commented 1 year ago

Alright, well I don't recommend it.

keifufu commented 1 year ago

Spotify web rating has been fixed by now. If you're using a chromium based browser you can install the web player as a PWA, to make it feel more like a desktop app if that's what you want.