search

keijiro / CloudSkybox

Skybox shader with volumetric clouds
MIT License
452 stars 59 forks source link

Wrong use of BeerPowder #1

Open yonoslaw opened 8 years ago

yonoslaw commented 8 years ago

Hi! Your code is great, very clean. I was working on a clouds shader for some days now but just as it was almost ready I found this. I found here some things I was missing in my version, thanks for sharing this. There is a small bug in your code. You are using the BeerPowder in a wrong way, it should be used for clouds pointing away from the sun. Now the BeerPowder makes a ugly black silhouettes around clouds that occlude sun. The second thing is the light loop. I could tune it fine with just <10 steps and without the random noise. I thinks the light steps should be much smaller.

keijiro commented 8 years ago

Thanks for the advice! This is just a quick and dirty hack at the moment... I should improve a lot for use in real applications. I'll look into the points you mentioned when I get time for improvement.