search

keijiro / HdrpVatExample

VAT (Vertex Animation Texture) with Unity Shader Graph and Visual Effect Graph
The Unlicense
881 stars 86 forks source link

would this example work in gamma space? #16

Closed sebas77 closed 1 year ago

sebas77 commented 1 year ago

as far as I know, unity changes the data in all 16bit formats regardless the srgb check

keijiro commented 1 year ago

I don't think it works because it's not about the precision but applying a special non-linear curve.

sebas77 commented 1 year ago

all right thanks, I suspect the srgb unchecked would keep the textures linear in HDRP, but not in URP. Same reason why VFX Graph doesn't work with URP gamma, but can work with HDRP gamma.

Do you agree?

Edit: I am starting to wonder if HDRP is only linear argh

keijiro commented 1 year ago

These two switches are different.

HDRP only supports linear workflow.

Gamma texture sampling is only meaningful in the linear workflow.

I think VAT supports both of these workflows but you shouldn't enable gamma texture sampling when using the linear workflow.

Note: I might be wrong. I haven't touched this project for three years. I can't remember the details.