keijiro / KinoGlitch

Video glitch effects for Unity
2.5k stars 231 forks source link

Support For LWRP? #11

Open ditpowuh opened 4 years ago

ditpowuh commented 4 years ago

I have tried to use KinoGlitch with a 2D project of mine that uses LWRP. It doesn't seem to work. Is it possible to make KinoGlitch work with LWRP? Thank you in advance.

keijiro commented 4 years ago

I'm thinking of porting Kino to URP from HDRP. I'll reconsider the possibility when the custom post processing effect support is added to URP.

ditpowuh commented 4 years ago

Ah, I see. Thank you for your response.

demonixis commented 4 years ago

Custom post-processing is possible using Render features.

Hellstellar commented 4 years ago

I would just like to know the progress for porting on urp as it isn't working as of now.

keijiro commented 4 years ago

@Hellstellar I've done nothing.

Hellstellar commented 4 years ago

Lol! well then will you do anything in the future? Or are you done with this. :).

keijiro commented 4 years ago

@Hellstellar I'm still waiting for post-processing support with URP. Even though it can be implemented using render features (as demonixis said), I think it's not an ideal solution.

demonixis commented 4 years ago

According to Unity render features are the way to create post process with URP. They indicated it's not supported because there is no official docs. I've a port of your analog glitch in URP using render feature, it works but I loose some other effects like the Bloom.

Hellstellar commented 4 years ago

@demonixis Is that port on your github? Can you share a link for the same.

demonixis commented 4 years ago

Not yet but I can add it in the coming days

Yihsien124 commented 2 years ago

Excuse me, is it possible to make KinoGlitch work with URP now?

shadiabolhasani commented 2 years ago

According to Unity render features are the way to create post process with URP. They indicated it's not supported because there is no official docs. I've a port of your analog glitch in URP using render feature, it works but I loose some other effects like the Bloom.

how? plz tell me.

3Samourai commented 1 year ago

UP

Hellstellar commented 1 year ago

Awesome

On Mon, 21 Aug 2023, 5:57 pm Samouraï, @.***> wrote:

UP

— Reply to this email directly, view it on GitHub https://github.com/keijiro/KinoGlitch/issues/11#issuecomment-1686234825, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFOLNCHUBIVHNV66EFWGGDXWNH3BANCNFSM4MF47JPQ . You are receiving this because you were mentioned.Message ID: @.***>

drewvancamp commented 2 months ago

@Hellstellar I'm still waiting for post-processing support with URP. Even though it can be implemented using render features (as demonixis said), I think it's not an ideal solution.

Hello! Has anything changed that would lead to a URP port of the glitch effect / Kino? Would love this.

ditpowuh commented 2 months ago

Hey all, someone else made an unofficial port of KinoGlitch over at this repository. It seems to be working (using version 2022.3.15f1 of Unity).

3Samourai commented 2 months ago

Hey all, someone else made an unofficial port of KinoGlitch over at this repository. It seems to be working (using version 2022.3.15f1 of Unity).

Not working in Unity 6 : error CS0619: 'RenderTargetHandle' is obsolete: 'Deprecated in favor of RTHandle'

ditpowuh commented 1 month ago

Hey all, someone else made an unofficial port of KinoGlitch over at this repository. It seems to be working (using version 2022.3.15f1 of Unity).

Not working in Unity 6 : error CS0619: 'RenderTargetHandle' is obsolete: 'Deprecated in favor of RTHandle'

I have made a fork of the repository over here, where the deprecation errors should be fixed.

However, this is a temporary fix as I have not updated the code to use the newer Render Graph API, and currently relies on compatibility mode where the Render Graph API is disabled. Meaning in a future Unity update, it may no longer work.