search

keijiro / MidiJack

MIDI input plugin for Unity
697 stars 113 forks source link

Integration with new InputSystem #41

Closed rsodre closed 5 years ago

rsodre commented 5 years ago

Not sure if it's possible to add a custom device to the new Input System, but would be nice to configure MIDI from there.

keijiro commented 5 years ago

Nice catch, but unfortunately, my conclusion is that it's not possible at the moment. The new system is well-designed for input devices with 10 or 20 control elements, but not for a device with 256 control elements (128 notes + 128 CCs).

I'll revisit the possibility when the new system is finalized.

rsodre commented 5 years ago

Btw, I created a request at Unity's own repository too. No comments yet... https://github.com/Unity-Technologies/InputSystem/issues/537

JimmyCushnie commented 5 years ago

@keijiro why do you feel the new input system is not well-designed for large devices? I looked through the "how to create custom devices" section of the documentation and it looks fine to me for large devices.

Furthermore, the new system handles (non-musical) keyboards just fine, and those have 110 inputs.

keijiro commented 5 years ago

@JimmyCushnie Right.

JimmyCushnie commented 5 years ago

...what? I think you may have responded to the wrong thread

keijiro commented 5 years ago

@JimmyCushnie I meant your understanding is right.

JimmyCushnie commented 5 years ago

Ah, so this has changed since you made your comment in April?

Do you think making a MidiJack port for the new input system is something you might now do, then?

keijiro commented 5 years ago

@JimmyCushnie No. I was just wrong.

I'll start a new project instead of extending MidiJack, I don't have time for a while though.

JimmyCushnie commented 5 years ago

That's excellent news, I look forwards to using your new project :)

keijiro commented 5 years ago

I finished the new project. Now you can get MIDI input via the new Input System.

https://github.com/keijiro/Minis

JimmyCushnie commented 5 years ago

Thank you for the notification. Your new system looks awesome, and I'll be using it in my project!