search

keijiro / Rsvfx

An example that shows how to connect RealSense depth camera to Unity VFX Graph
Other
734 stars 111 forks source link

Rsvfx doesn't use full frame data #31

Closed codeKenner closed 5 years ago

codeKenner commented 5 years ago

Hey Keijiro, first of all, very nice work with the Rsvfx. I noticed, that your implementation only uses part of the information captured by the Realsense camera. The frame seams to be cropped on all 4 edges when compared to the visual in the Intel Realsense Viewer. I did try 2 resolutions, 640x480px as well as 1280x720px. Setup works fine except for the crop. Any hints on that?

keijiro commented 5 years ago

Which RealSense device are you using? D435 has a bit strange FoV setting, so it will be cropped when using color and depth at the same time. Please understand that it's "by-design". If you're using D415, this problem shouldn't be happened.

codeKenner commented 5 years ago

Keijiro, thank you for the quick response. It‘s the D435 I‘m using. So I understand your point about it being „by design“. Can I use the depth info only with full info as a input into the vfx?

keijiro commented 5 years ago

How about changing this line to “bool mask = true;” ? I can’t remember the details, but I think this mask thing does cropping.

On Oct 30, 2019, at 15:20, codeKenner notifications@github.com wrote:

 Keijiro, thank you for the quick response. It‘s the D435 I‘m using. So I understand your point about it being „by design“. Can I use the depth info only with full info as a input into the vfx?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

keijiro commented 5 years ago

Oops. Forgot to paste the URL.

https://github.com/keijiro/Rsvfx/blob/ab16a0dcb3daa41caf9eee5a16efe6e5c3878fb1/Assets/Rsvfx/Runtime/DepthConverter.compute#L46

keijiro commented 5 years ago

I'm closing this issue now as the problem has been solved. Please feel free to reopen for further problems.