keijiro / ShaderGraphAssets

Basic asset collection for Unity Shader Graph
The Unlicense
181 stars 8 forks source link

Chromakey node strange behavior in versions below 2021.2 #1

Closed spxyz closed 2 years ago

spxyz commented 2 years ago

Hi, thanks for your great assets. I am having issues with chromakey node. Something strange with colors in unity version below 2021.2(HDRP setup):

keyHDRP

keijiro commented 2 years ago

Does it reproduce on URP with Gamma color space setting?

I guess that this issue is caused by Linear color space setting.

spxyz commented 2 years ago

That's what I thought, but:

[2021.2] Start new HDRP project (linear color space), import ShaderGraphAssets package - OK [2021.2] Start new URP project (gamma color space), import ShaderGraphAssets package - OK

[2020.3] Start new HDRP project (linear color space), import ShaderGraphAssets package - FAIL [2020.3] Start new URP project (gamma color space), import ShaderGraphAssets package - FAIL

keijiro commented 2 years ago

Thanks for the clarification. Sure, I should deep-dive into it.

keijiro commented 2 years ago

I found there is a compatibility-breaking change in the Swizzle node (it's actually upper compatible but not backward compatible). I think I can solve it by re-editing it in 2020.3.

keijiro commented 2 years ago

Fixed in 1.0.5

keijiro commented 2 years ago

I'm closing this issue now. Please feel free to reopen it if it still reproduces on your side.

spxyz commented 2 years ago

You're the Best!