search

keijiro / jp.keijiro.ffmpeg-out

UPM package repository for FFmpegOut.
https://github.com/keijiro/FFmpegOut
Other
11 stars 3 forks source link

ffmpeg-out on OpenUPM #1

Open favoyang opened 4 years ago

favoyang commented 4 years ago

Hi @keijiro,

Thanks for creating the amazing project. I'm the creator of OpenUPM, a public upm registry with automatic build pipelines that publish new package bundle based on valid git tags. You can read the announcement to get the basic idea, so far it hosts 80+ packages as of December 2019.

I would like to include this package. However I have a quick question for the ffmpeg's GPL license. Since you included the binary of ffmpeg, will this affect the license of projects rely on this package?

Please also make a GitHub Release for v1.0.5 when you have time.

keijiro commented 4 years ago

However I have a quick question for the ffmpeg's GPL license. Since you included the binary of ffmpeg, will this affect the license of projects rely on this package?

I am not a lawyer. Sorry but I wouldn't like to take a risk of giving a wrong advice. Please see the LICENSE file.

Please also make a GitHub Release for v1.0.5 when you have time.

This repository is mainly used via Git support on Package Manager or the npm.js registry. That's why I've never used the Releases page.

If you solve the license concerns and still need Releases files, please ping me again. This issue will be closed until then.

favoyang commented 4 years ago

@keijiro, thanks for the response.

  1. I have read your dual license carefully. I would suggest split to two separated packages and let the ffmpeg-out depends on the ffmpeg binary, so each has a clear single license. But I understand the combined package is most for convenience. So just keep it no change is fine.

  2. I would still like to require a GitHub release for this repository if that is possible. OpenUPM is a new service to create a more unified experience for consuming upm packages. Our build pipelines watch GitHub releases and build packages for you (2-8 mins after you create the GitHub releases). So it's not conflict with your npm.js release.

I would also suggest semantic-release-action to make thing automatic. I just help a project convert to upm, the author use the tool to automate some workflows.

  1. I would like to also add other your popular unity repositories/upm packages. If the platform (hopefully) makes sense for you.