keikoproj / alert-manager

alert-manager provides CRD implementation for wavefront alerts, splunk alerts etc.,
10 stars 10 forks source link

Standalone alert shouldn't be allowed to use in AlertsConfig #34

Closed mnkg561 closed 3 years ago

mnkg561 commented 3 years ago

Is this a BUG REPORT or FEATURE REQUEST?: Bug

What happened: As part of the demo/testing we used a stand alone alert in AlertsConfig and it created WavefrontAlert. The expectation is it should error out if a WavefrontAlert doesn't have any exportedParam fields otherwise its just a duplicate since there are no changes from original WavefrontAlert which was already created as part of Standalone Wavefront Alert.

What you expected to happen: It should error out with stating that there is no exportParams field in the WavefrontAlert.

How to reproduce it (as minimally and precisely as possible):

  1. Create Wavefront stand alone alert
  2. Use that in one of the AlertsConfig

This will have 2 alerts in wavefront without any changes(duplicates)

Anything else we need to know?:

Environment:

Other debugging information (if applicable):

- controller logs:

$ kubectl logs