keikoproj / lifecycle-manager

Graceful AWS scaling event on Kubernetes using lifecycle hooks
Apache License 2.0
93 stars 28 forks source link

Allow drain retries even with timeout failures #104

Closed shreyas-badiger closed 1 year ago

shreyas-badiger commented 1 year ago

Fixes https://github.com/keikoproj/lifecycle-manager/issues/90

codecov[bot] commented 1 year ago

Codecov Report

Merging #104 (cc82768) into master (eea6b4b) will decrease coverage by 0.28%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   71.02%   70.74%   -0.28%     
==========================================
  Files          12       12              
  Lines        1239     1234       -5     
==========================================
- Hits          880      873       -7     
- Misses        296      298       +2     
  Partials       63       63              
Impacted Files Coverage Δ
pkg/service/manager.go 67.66% <ø> (ø)
pkg/service/nodes.go 81.98% <87.50%> (-1.92%) :arrow_down:
pkg/service/server.go 60.33% <90.00%> (-0.05%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more