keikoproj / lifecycle-manager

Graceful AWS scaling event on Kubernetes using lifecycle hooks
Apache License 2.0
93 stars 28 forks source link

Log node/ec2 instance name on nodes.drainNode error #115

Open karimlakhani opened 1 year ago

karimlakhani commented 1 year ago

Is this a BUG REPORT or FEATURE REQUEST?: feature request What happened: error logging does not include the node name / ec2 instance id What you expected to happen: when logging the error, include the node name / ec2 instance id How to reproduce it (as minimally and precisely as possible): you need the drainNode to fail for some reason other than if err.Error() == "command execution timed out" { Anything else we need to know?:

Environment: ALl

Other debugging information (if applicable): this is the code https://github.com/keikoproj/lifecycle-manager/blob/7084174977de0a30f20fa2ba8e545383f4067575/pkg/service/nodes.go#LL67C1-L68C1

kubectl logs <lifecycle-manager-pod>