keikoproj / lifecycle-manager

Graceful AWS scaling event on Kubernetes using lifecycle hooks
Apache License 2.0
94 stars 28 forks source link

only do alb deregister for nodes with specific label #207

Closed ZihanJiang96 closed 2 months ago

ZihanJiang96 commented 2 months ago

skip alb deregistration if the node doesn't have label lifecycle-manager.keikoproj.io/enable-alb-deregister set to "true"

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.58%. Comparing base (87c603d) to head (298eeec).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #207 +/- ## ========================================== + Coverage 66.52% 66.58% +0.05% ========================================== Files 15 15 Lines 1168 1170 +2 ========================================== + Hits 777 779 +2 Misses 319 319 Partials 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.