search

keikoproj / lifecycle-manager

Graceful AWS scaling event on Kubernetes using lifecycle hooks
Apache License 2.0
93 stars 28 forks source link

Allow drain retries even with timeout failures. #91

Closed shreyas-badiger closed 1 year ago

shreyas-badiger commented 1 year ago

Fixes https://github.com/keikoproj/lifecycle-manager/issues/90

garomonegro commented 1 year ago

Just a thought, doesn't need to be addressed in this PR: Any reason why we are still using vendor? Do we need to keep using it?

shreyas-badiger commented 1 year ago

Just a thought, doesn't need to be addressed in this PR: Any reason why we are still using vendor? Do we need to keep using it?

@garomonegro Good point. Even I wasn't sure why we need the vendors. However, they all got updated when I ran go mod tidy and go get <missing_modules>. Maybe should create another ticket to cleanup the vendors?

kevdowney commented 1 year ago

We can probably remove the entire /vendor dir here. Submitted PR: https://github.com/keikoproj/lifecycle-manager/pull/94

kevdowney commented 1 year ago

@shreyas-badiger Does this change simply add more retry and not change it's behavior in any other ways?

shreyas-badiger commented 1 year ago

@shreyas-badiger Does this change simply add more retry and not change it's behavior in any other ways?

That's right. It allows drain retries even when there is a timeout error and also makes drain retry attempts configurable.